chore: upgrade to net10.0-android and add NuGet packaging metadata#13
Merged
Conversation
- Upgrade target framework from net8.0-android34.0 to net10.0-android - Upgrade tests from net8.0 to net10.0 - Add NuGet packaging metadata (Version, License, Readme, SourceLink, snupkg) - Add GeneralUpdate.Avalonia.slnx to manage src projects - Update global.json to use latestMajor rollForward - Fix SupportedOSPlatformVersion from 21 to 26 - Update .gitignore to exclude .idea/ - Update README with new target framework info Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Android library and its tests to .NET 10 and adds NuGet packaging metadata so GeneralUpdate.Avalonia.Android can be published as a package.
Changes:
- Upgrade TFMs:
GeneralUpdate.Avalonia.Android→net10.0-android, tests →net10.0. - Add NuGet package metadata (license, repo links, symbols/snupkg settings, readme packing).
- Add a
.slnxsolution file for thesrcfolder.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/GeneralUpdate.Avalonia.Android.Tests/GeneralUpdate.Avalonia.Android.Tests.csproj | Moves test project to net10.0. |
| src/GeneralUpdate.Avalonia.slnx | Adds solution definition for the Android project. |
| src/GeneralUpdate.Avalonia.Android/GeneralUpdate.Avalonia.Android.csproj | Upgrades to net10.0-android, updates min API level, and adds NuGet packaging metadata. |
| README.md | Updates prerequisites to mention .NET 10 / net10 Android. |
| global.json | Updates SDK selection behavior via rollForward/prerelease settings. |
| .gitignore | Attempts to add IDE ignore entry (but currently introduces a malformed line). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+5
| "version": "8.0.100", | ||
| "rollForward": "latestMajor", | ||
| "allowPrerelease": true |
Comment on lines
34
to
36
| <ItemGroup> | ||
| <PackageReference Include="Xamarin.AndroidX.Core" Version="1.13.1.2" /> | ||
| </ItemGroup> |
- Pin global.json SDK to 10.0.100 (net10.0 requires 10.x SDK) - Add Microsoft.SourceLink.GitHub package reference for proper SourceLink - Update README: remove net8.0 references, require only net10.0 - Add .idea/ to .gitignore Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
All 3 review comments have been addressed in commit 1bd7c02:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Summary
Prepares
GeneralUpdate.Avalonia.Androidfor NuGet publishing by adding proper packaging metadata and upgrading to .NET 10.Key changes
net8.0-android34.0tonet10.0-androidsrc/GeneralUpdate.Avalonia.slnxVerification
.nupkgand.snupkgoutputs